Fix Load Data from CSV File for Value Map widget #60786
Conversation
agiudiceandrea
added
Bug
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
agiudiceandrea
force-pushed
the
fix-60765-loaddatafromcsv
branch
from
1857f92 to
7b2415c
Compare
agiudiceandrea
changed the title
| @@ -402,11 +404,11 @@ void QgsValueMapConfigDlg::loadMapFromCSV( const QString &filePath ) | |||
| ceils << match.capturedTexts().last().trimmed().replace( QLatin1String( "\"\"" ), QLatin1String( "\"" ) ); | |||
| } | |||
|
|
|||
| if ( ceils.size() != 2 ) | |||
| if ( ceils.size() == 0 ) | |||
There was a problem hiding this comment.
@agiudiceandrea
Since the cells.size() > 2 is gone, just wanted to ask you if that's on purpose or if it's still safe.
There was a problem hiding this comment.
Thanks for the review!
If my logic isn't faulty, the QStringList ceils is populated in a previous while ( matches.hasNext() && ceils.size() < 2 ) loop, so it cannot have a size greater than 2: its size can only be either 0 or 1 or 2. If its size is 0, then outside loop will continue, if it's 1 then key = ceils[0] and val = QString( "" ), if it's 2 then key = ceils[0] and val = ceils[1].
There was a problem hiding this comment.
I missed that part, thanks for the explanation!
Description
set UTF-8 codec when reading the CSV file
correctly handle CSV file with a single column without a trailing comma, like
while currently only a CSV like the following one is allowed
Fixes #60765.