Some fixes in measure 3d #60849
Open
Some fixes in measure 3d #60849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uclaros
added
3D
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Mar 11, 2025
src/3d/qgsrubberband3d.cpp
Outdated
| @@ -140,6 +140,32 @@ void QgsRubberBand3D::setupPolygon( Qt3DCore::QEntity *parentEntity ) | |||
| mPolygonEntity->addComponent( mPolygonMaterial ); | |||
| } | |||
|
|
|||
| void QgsRubberBand3D::removePoint( int index ) | |||
| { | |||
| if ( QgsPolygon *polygon = qgsgeometry_cast<QgsPolygon *>( mGeometry.constGet() ) ) | |||
There was a problem hiding this comment.
You're abusing API here. You're using constGet(), but then modifying the geometry! 😱
Bit this points out a bad issue -- you shouldn't be allowed to qgsgeometry_cast a const geometry pointer to a non-const one. PR incoming...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description