-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Build pdal from source in the qt5 version to avoid ubuntugis ppa #60949
base: master
Are you sure you want to change the base?
Conversation
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this ! this looks OK to me
Additionally I suggest to switch to NodeJS LTS, avoiding to specify a version on this line: RUN echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_lts.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list See: https://github.com/nodesource/distributions?tab=readme-ov-file#using-ubuntu-nodejs-lts |
42457aa
to
63c4cad
Compare
Good idea. Done. |
aae8964
to
a3cafe8
Compare
Test failures are the side-effect of the downgrade from gdal 3.9 (from ubuntugis) to 3.8 (from ubuntu repos). They'll need to be adapted accordingly and add version-specific checks |
The docker image used to compile the linux qt5 version and to launch the unit tests is based on ubuntu 24.04. However, this version does not provide the PDAL package anymore. As a workaround, the `ubuntugis` ppa has been added to get PDAL. However, this may introduce some package installation conflicts. This issue is fixed by downloading the latest PDAL version and compile it. This way, the ubuntugis ppa can be removed and this solve the installation conflicts. With this change, it is now necessary to install `GDAL` and `PROJ` dev packages in the `binary-only` only image because they are needed to compile PDAL from source.
This reverts commit b3cdf9e. With the ubuntugis ppa removed, grass can now be installed.
a3cafe8
to
23cb4e8
Compare
Description
The docker image used to compile the linux qt5 version and to launch
the unit tests is based on ubuntu 24.04. However, this version does
not provide the PDAL package anymore. As a workaround, the
ubuntugis
ppa has been added to get PDAL. However, this may introduce some
package installation conflicts.
This issue is fixed by downloading the latest PDAL version and compile
it. This way, the ubuntugis ppa can be removed and this solve the
installation conflits. With this change, it is now necessary to
install
GDAL
andPROJ
dev packages in thebinary-only
onlyimage because they are needed to compile PDAL from source.
See: #60905
Funded by Oslandia