Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build pdal from source in the qt5 version to avoid ubuntugis ppa #60949

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ptitjano
Copy link
Collaborator

Description

The docker image used to compile the linux qt5 version and to launch
the unit tests is based on ubuntu 24.04. However, this version does
not provide the PDAL package anymore. As a workaround, the ubuntugis
ppa has been added to get PDAL. However, this may introduce some
package installation conflicts.

This issue is fixed by downloading the latest PDAL version and compile
it. This way, the ubuntugis ppa can be removed and this solve the
installation conflits. With this change, it is now necessary to
install GDAL and PROJ dev packages in the binary-only only
image because they are needed to compile PDAL from source.

See: #60905

Funded by Oslandia

@github-actions github-actions bot added this to the 3.44.0 milestone Mar 11, 2025
@ptitjano ptitjano added the CI/GitHub-Actions issues related to GitHub Actions label Mar 11, 2025
@ptitjano ptitjano self-assigned this Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 23cb4e8)

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 23cb4e8)

Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this ! this looks OK to me

@Guts
Copy link
Contributor

Guts commented Mar 11, 2025

Additionally I suggest to switch to NodeJS LTS, avoiding to specify a version on this line:

RUN echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_lts.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list

See: https://github.com/nodesource/distributions?tab=readme-ov-file#using-ubuntu-nodejs-lts

@ptitjano ptitjano force-pushed the pdal-ubuntu-ci-ok branch 2 times, most recently from 42457aa to 63c4cad Compare March 11, 2025 15:20
@ptitjano
Copy link
Collaborator Author

Additionally I suggest to switch to NodeJS LTS, avoiding to specify a version on this line:

RUN echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_lts.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list

See: https://github.com/nodesource/distributions?tab=readme-ov-file#using-ubuntu-nodejs-lts

Good idea. Done.

@ptitjano ptitjano force-pushed the pdal-ubuntu-ci-ok branch 2 times, most recently from aae8964 to a3cafe8 Compare March 11, 2025 16:14
@nyalldawson
Copy link
Collaborator

Test failures are the side-effect of the downgrade from gdal 3.9 (from ubuntugis) to 3.8 (from ubuntu repos). They'll need to be adapted accordingly and add version-specific checks

The docker image used to compile the linux qt5 version and to launch
the unit tests is based on ubuntu 24.04. However, this version does
not provide the PDAL package anymore. As a workaround, the `ubuntugis`
ppa has been added to get PDAL. However, this may introduce some
package installation conflicts.

This issue is fixed by downloading the latest PDAL version and compile
it. This way, the ubuntugis ppa can be removed and this solve the
installation conflicts. With this change, it is now necessary to
install `GDAL` and `PROJ` dev packages in the `binary-only` only
image because they are needed to compile PDAL from source.
This reverts commit b3cdf9e.

With the ubuntugis ppa removed, grass can now be installed.
@ptitjano ptitjano force-pushed the pdal-ubuntu-ci-ok branch from a3cafe8 to 23cb4e8 Compare March 12, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/GitHub-Actions issues related to GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants