-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crashes in oracle provider when db workspace is set #60957
Conversation
…orkspace is set Fixes crashes in oracle provider when db workspace is set.
(This is NOT possible to unit test) |
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
I tested this pull request and it fixed the problem for me when connecting to oracle layers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_40 release-3_40
# Navigate to the new working tree
cd .worktrees/backport-release-3_40
# Create a new branch
git switch --create backport-60957-to-release-3_40
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 3643a2947f731d1b146d01e7a75c9ac36c580e8f,63224c215195d670e2510cbf4cbadd0a5c627458
# Push it to GitHub
git push --set-upstream origin backport-60957-to-release-3_40
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_40 Then, create a pull request where the |
When a workspace was set, we were using a different connection ID string when creating a connection in the connection pool vs when we were destroying it. This triggered an assert, resulting in crashes when connections were invalidated.