Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding qiskit dependencies to docs group #41

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

The docs deployment is failing because #39 made qiskit* dependencies optional, and they were only added to the tests group but not the docs one. This PR addresses the matter.

@alecandido
Copy link
Member

This is something I should fix in the workflows' repo: the docs should be compiled even in branches, even if not published.

This is partially covered by the doctests, whenever there are any. But it's the wrong place (fine to have it, but we should not rely on it), we also need a dry run of the publishing workflow.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi marked this pull request as ready for review October 14, 2024 09:36
@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi merged commit 5e6391c into main Oct 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants