Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result shapes #825

Closed
wants to merge 1 commit into from
Closed

Fix result shapes #825

wants to merge 1 commit into from

Conversation

alecandido
Copy link
Member

Currently, result shapes are broken for the QICK drivers, as reported by @JavierSerranoGarcia in qiboteam/qibocal#737

However, it seems like the tests in https://github.com/qiboteam/qibolab/blob/595351782d55a20fa2b8c35104c000092e42f585/tests/test_result_shapes.py are also broken for iqm5q (currently using Zurich, in a pretty weird way.

I'm trying to understand how this is happening, but Qibocal seems properly compensating, since the resonator_spectroscopy routine is then properly working.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@alecandido
Copy link
Member Author

Maybe @hay-k could also have an idea, given his work on #797

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.13%. Comparing base (5953517) to head (f5b2692).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #825   +/-   ##
=======================================
  Coverage   65.13%   65.13%           
=======================================
  Files          50       50           
  Lines        6031     6031           
=======================================
  Hits         3928     3928           
  Misses       2103     2103           
Flag Coverage Δ
unittests 65.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido alecandido added bug Something isn't working qick labels Mar 1, 2024
@alecandido
Copy link
Member Author

Superseded by #843

@alecandido alecandido closed this Mar 25, 2024
@alecandido alecandido deleted the debug-qibocal-737 branch August 5, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant