Skip to content
This repository was archived by the owner on Sep 23, 2023. It is now read-only.

Fix layout - #692

Open
ElDeveloper wants to merge 5 commits into
qiime:masterfrom
ElDeveloper:issue-681-1
Open

Fix layout#692
ElDeveloper wants to merge 5 commits into
qiime:masterfrom
ElDeveloper:issue-681-1

Conversation

@ElDeveloper

Copy link
Copy Markdown
Member

This is probably not done yet but I think that what I left is what should be there, I think this will be a good way to start the conversation.

@teravest

Copy link
Copy Markdown
Contributor

Do you have this on webdev?

On Mon, Apr 28, 2014 at 11:35 AM, Yoshiki Vázquez Baeza <
notifications@github.com> wrote:

This is probably not done yet but I think that what I left is what should

be there, I think this will be a good way to start the conversation.

You can merge this Pull Request by running

git pull https://github.com/ElDeveloper/qiime_web_app issue-681-1

Or view, comment on, or merge it at:

#692
Commit Summary

  • BUG: Change layout of map key
  • MAINT: Remove unused code
  • BUG: Re-center form
  • ENH: Remove unused parts and center the form

File Changes

  • M www/americangut/register_user.psphttps://github.com/Fix layout #692/files#diff-0(35)
  • M www/americangut/style/americangut.csshttps://github.com/Fix layout #692/files#diff-1(16)

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/692
.

@ElDeveloper

Copy link
Copy Markdown
Member Author

I most certainly do 👍

On Apr 28, 2014, at 11:38 AM, teravest notifications@github.com wrote:

Do you have this on webdev?

On Mon, Apr 28, 2014 at 11:35 AM, Yoshiki Vázquez Baeza <
notifications@github.com> wrote:

This is probably not done yet but I think that what I left is what should

be there, I think this will be a good way to start the conversation.

You can merge this Pull Request by running

git pull https://github.com/ElDeveloper/qiime_web_app issue-681-1

Or view, comment on, or merge it at:

#692
Commit Summary

  • BUG: Change layout of map key
  • MAINT: Remove unused code
  • BUG: Re-center form
  • ENH: Remove unused parts and center the form

File Changes

  • M www/americangut/register_user.psphttps://github.com/Fix layout #692/files#diff-0(35)
  • M www/americangut/style/americangut.csshttps://github.com/Fix layout #692/files#diff-1(16)

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/692
.


Reply to this email directly or view it on GitHub.

@teravest

Copy link
Copy Markdown
Contributor

register_user.psp is still using the old mapping code, (not the cashed versions)
You should strip out all the mapping code and add
<%@include file="loggedoutheader.psp"%>
<%@include file="drawmap.psp"%>
<%@include file="loggedoutmenu.psp"%>

The layout is looking better but the page is still broken.
@ElDeveloper

Copy link
Copy Markdown
Member Author

@teravest, I'm having a couple issues with this, will look at it later, maybe it will be easier if you help me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants