-
Notifications
You must be signed in to change notification settings - Fork 8
update #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update #96
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package healthcheck | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "math" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestCommon(t *testing.T) { | ||
| baseTh := 97.0 | ||
|
|
||
| newThreshold := baseTh - math.Ceil(baseTh*0.01) | ||
| fmt.Println(newThreshold) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,67 +1,11 @@ | ||
| package receiver | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "os" | ||
|
|
||
| "github.com/gin-gonic/gin" | ||
| ) | ||
|
|
||
| var ( | ||
| cfgBasicUser string | ||
| cfgBasicPass string | ||
| cfgBearer string | ||
| ) | ||
|
|
||
| // ConfigureAuth sets credentials for webhook auth (config-driven). Empty values disable that auth type. | ||
| func ConfigureAuth(user, pass, bearer string) { | ||
| cfgBasicUser = user | ||
| cfgBasicPass = pass | ||
| cfgBearer = bearer | ||
| } | ||
|
|
||
| func authEnabled() bool { | ||
| // prefer config | ||
| if cfgBasicUser != "" || cfgBasicPass != "" || cfgBearer != "" { | ||
| return true | ||
| } | ||
| // fallback to env for backward compatibility | ||
| return os.Getenv("ALERT_WEBHOOK_BASIC_USER") != "" || | ||
| os.Getenv("ALERT_WEBHOOK_BASIC_PASS") != "" || | ||
| os.Getenv("ALERT_WEBHOOK_BEARER") != "" | ||
| } | ||
| // ConfigureAuth is a no-op; authentication disabled at source. | ||
| func ConfigureAuth(user, pass, bearer string) {} | ||
|
|
||
| // AuthMiddleware returns false if unauthorized and writes a 401 response. | ||
| func AuthMiddleware(c *gin.Context) bool { | ||
| if !authEnabled() { | ||
| return true | ||
| } | ||
|
|
||
| // prefer config | ||
| user := cfgBasicUser | ||
| pass := cfgBasicPass | ||
| bearer := cfgBearer | ||
| // fallback to env if not set in config | ||
| if user == "" && pass == "" && bearer == "" { | ||
| user = os.Getenv("ALERT_WEBHOOK_BASIC_USER") | ||
| pass = os.Getenv("ALERT_WEBHOOK_BASIC_PASS") | ||
| bearer = os.Getenv("ALERT_WEBHOOK_BEARER") | ||
| } | ||
|
|
||
| if user != "" || pass != "" { | ||
| u, p, ok := c.Request.BasicAuth() | ||
| if !ok || u != user || p != pass { | ||
| c.JSON(http.StatusUnauthorized, map[string]any{"ok": false, "error": "unauthorized"}) | ||
| return false | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| if bearer != "" { | ||
| if c.GetHeader("Authorization") != "Bearer "+bearer { | ||
| c.JSON(http.StatusUnauthorized, map[string]any{"ok": false, "error": "unauthorized"}) | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| } | ||
| func AuthMiddleware(c *gin.Context) bool { return true } | ||
|
Comment on lines
+7
to
+11
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个测试函数
TestCommon只是打印了一个计算结果,并没有使用任何断言来验证其正确性。一个有效的单元测试应该包含明确的输入、预期输出和断言。如果这只是一个用于临时调试的测试,请在合并前将其移除或完善成一个真正的测试用例。