Skip to content

Build on Windows on Arm too in the Windows nightly#880

Open
jonathonpenix wants to merge 1 commit intoqualcomm:mainfrom
jonathonpenix:wos_builder
Open

Build on Windows on Arm too in the Windows nightly#880
jonathonpenix wants to merge 1 commit intoqualcomm:mainfrom
jonathonpenix:wos_builder

Conversation

@jonathonpenix
Copy link
Contributor

No description provided.

@@ -1,19 +1,30 @@
name: Windows Nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the name accordingly to include Windows on ARM/Regular windows ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Looks like some tests are failing though, which is interesting.

I'm going to let the run finish before updating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, hopefully this looks ok


on:
# pull_request: {} # Uncomment only to test this WF file update.
pull_request: {} # Uncomment only to test this WF file update.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment this before merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and removed this now since I'm only changing the name.

@quic-seaswara
Copy link
Contributor

clang++ : error : unsupported option '-fpic' for target 'x86_64-pc-windows-msvc' [C:\a\eld\eld\nightly\obj\tools\eld\test\check-eld-test-x86-default.vcxproj]

@jonathonpenix
Copy link
Contributor Author

jonathonpenix commented Feb 27, 2026

Oh, x86/Arm builds agree on failures at least (and it matches the current nightly) so I guess that isn't so bad.

Saving link to run before updating: https://github.com/qualcomm/cpullvm-toolchain/actions/runs/22433777813/job/64965506504?pr=203

@jonathonpenix jonathonpenix marked this pull request as ready for review February 27, 2026 00:51
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yikes, this probably also needs to change I guess.

Will look at/fix this later.

@jonathonpenix jonathonpenix marked this pull request as draft February 27, 2026 00:54
@jonathonpenix jonathonpenix marked this pull request as ready for review March 11, 2026 20:34
@jonathonpenix
Copy link
Contributor Author

Test run with latest changes: https://github.com/qualcomm/eld/actions/runs/22966513252?pr=880

The failures match between the x86 and Arm64 runs and the failures are consistent with what is observed in eld's latest x86 Windows nightly (https://github.com/qualcomm/eld/actions/runs/22934436868/job/66562575650). So, calling these unrelated.

Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants