Add initial-exec to picolibc workflow#882
Conversation
| llvm-target: AArch64 | ||
| picolibc-default-config: "" | ||
| picolibc-no-tls: "-Dthread-local-storage=false" | ||
| picolibc-tls-ie: "-Dtls_model=initial-exec" |
There was a problem hiding this comment.
Dont change the default, add a new one
There was a problem hiding this comment.
I think what I did is add a new step, I didn't change the default config.
picolibc-tls-ie is only used in in this step:
name: Build Picolibc for ${{ matrix.arch.name }}, tls-ie
Do you want it in its own file? Because from what I understand I didn't change the default...
There was a problem hiding this comment.
Ok. I see the full change now.
quic-seaswara
left a comment
quic-seaswara
left a comment
There was a problem hiding this comment.
LGTM, @quic-k can you please check this out!
| llvm-target: AArch64 | ||
| picolibc-default-config: "" | ||
| picolibc-no-tls: "-Dthread-local-storage=false" | ||
| picolibc-tls-ie: "-Dtls_model=initial-exec" |
There was a problem hiding this comment.
Ok. I see the full change now.
| name: nightly picolibc builder | ||
|
|
||
| on: | ||
| # pull_request: {} # Uncomment only to test this WF file update. |
There was a problem hiding this comment.
can you uncomment this line temporarily to run nightly workflow for this PR
There was a problem hiding this comment.
https://github.com/qualcomm/eld/pull/882/checks?check_run_id=65091991154
DCO failed
you need to commit with -s
There was a problem hiding this comment.
ok, ignore that, just needed maintainer approval to run the workflow
lets see which all archs work with inital-exec
| mkdir -p build-clang-${{ matrix.arch.name }}-picolibc-no-tls | ||
| cd build-clang-${{ matrix.arch.name }}-picolibc-no-tls |
There was a problem hiding this comment.
name build dir build-clang-${{ matrix.arch.name }}-picolibc-tls-ie for the intial-exec variant, right now it is conflicting with the no-tls config build dir
| llvm-target: RISCV | ||
| picolibc-default-config: "" | ||
| picolibc-no-tls: "-Dthread-local-storage=false" | ||
| picolibc-tls-ie: "-Dtls_model=initial-exec" |
There was a problem hiding this comment.
config flag is tls-model and not tls_model
namikukr-qc
force-pushed
the
tls-workflow
branch
from
115e224 to
6d8ec31
Compare
| cd ${{ github.workspace }}/picolibc/build-clang-${{ matrix.arch.name }}-picolibc-default-config | ||
| ninja test | ||
|
|
||
| - name: Run Picolibc tests for ${{ matrix.arch.name }}, no-tls |
There was a problem hiding this comment.
you missed adding the run step for tls-ie, similar to this one, just cd to correct dir and run `ninja test1
|
CI looks good https://github.com/qualcomm/eld/actions/runs/22637687168?pr=882, riscv32 has unrelated fails @namikukr-qc can you re-comment line 4 and squash everything into one commit to prepare this for merge |
Adding tls-initial-exec as a workflow for picolibc builds. Signed-off-by: Namish Kukreja <namikukr@qti.qualcomm.com>
namikukr-qc
force-pushed
the
tls-workflow
branch
from
a7e7e2b to
3f5c5e5
Compare
Done in latest patch. |
quic-k
left a comment
quic-k
left a comment
There was a problem hiding this comment.
LGTM
thanks for working on this @namikukr-qc
3 participants
Adding tls-initial-exec as a workflow for picolibc builds.