Separate ctors/dtors and init_array/fini_array sections#933
Open
quic-k wants to merge 1 commit intoqualcomm:mainfrom
Open
Separate ctors/dtors and init_array/fini_array sections#933quic-k wants to merge 1 commit intoqualcomm:mainfrom
quic-k wants to merge 1 commit intoqualcomm:mainfrom
Conversation
Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
quic-seaswara
requested changes
Mar 11, 2026
| PROVIDE_HIDDEN ( __init_array_end = . ); | ||
| PROVIDE_HIDDEN ( __bothinit_array_end = . ); | ||
| } | ||
| PROVIDE_HIDDEN ( __bothinit_array_end = . ); |
Contributor
There was a problem hiding this comment.
why do we need these symbols bothinit_array_{start,end} ?
| KEEP (*(.fini_array .dtors)) | ||
| KEEP (*(SORT_BY_INIT_PRIORITY(.fini_array.*))) | ||
| KEEP (*(.fini_array)) | ||
| KEEP (*(.fini_array*)) |
Contributor
There was a problem hiding this comment.
Why this special handling ? Do we see .fini_array* ?
parth-07
reviewed
Mar 11, 2026
Contributor
parth-07
left a comment
parth-07
left a comment
There was a problem hiding this comment.
Can you please briefly describe why these changes are required?
Contributor
ctors and init_array need to be in seperate sections |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.