Build directory search lists once instead of parsing strings by quic-parihar · Pull Request #290 · qualcomm/fastrpc

quic-parihar · 2026-02-04T05:20:22Z

Convert ADSP library and AVS search paths from concatenated env/config strings into persistent QList-backed directory lists built at init time. This removes repeated parsing of ';'-delimited path strings on every fopen call and avoids reconstructing combined search paths for each lookup.

The new logic initializes two global directory lists (library and AVS) during apps_std_init(). Paths from environment variables and config files are parsed once and stored as individual nodes. All file lookup APIs are updated to walk these lists directly instead of reparsing a flat string.

This improves efficiency, reduces string and handling complexity. Legacy behavior is preserved for custom environment variables that do not match the standard ADSP_* and DSP_* path names.

Also update open_shell() to use the global list instead of constructing a temporary ";"-delimited directory list.

ekanshibu · 2026-02-17T10:26:09Z

src/apps_std_imp.c

+  FARF(RUNTIME_RPC_LOW, "Entering %s", __func__);
+
+  pthread_mutex_lock(&global_dirlist_mt);
+


too many empty lines in this function

ekanshibu · 2026-02-17T10:26:33Z

src/apps_std_imp.c

+#define DELIM ";"
+
+/**
+ * Helper function to add a path to a global directory list


function header is not proper

ekanshibu · 2026-02-17T10:27:35Z

inc/apps_std_internal.h

+};
+
+/**
+ * @brief Try to open a file from the global directory list


follow the standard commenting guideline

ekanshibu · 2026-02-18T05:50:26Z

inc/apps_std_internal.h

+/**
+ * @brief Structure to hold a single directory path in the global list
+ */
+struct dir_path_node {


if this is used only in apps_std_imp.c, better to move this there

ekanshibu · 2026-02-18T05:57:11Z

src/fastrpc_apps_user.c

-    }
  }
+  if (nErr) {
+    absNameLen = strlen(VENDOR_DOM_LOCATION) + shell_absNameLen + 1;


should this be VENDOR_DSP_LOCATION instead of VENDOR_DOM_LOCATION

no it will be VENDOR_DOM_LOCATION, abs name is carrying vendor DSP + subsystem name

ekanshibu · 2026-02-18T05:59:02Z

src/fastrpc_config_parser.c

+      }
+
+      if (path_len > 0) {
+        strncpy(single_path, path_start, path_len);


can path_len become >=PATH_MAX?

ekanshibu · 2026-02-18T06:02:45Z

inc/apps_std_internal.h

@@ -5,6 +5,7 @@
 #define __APPS_STD_INTERNAL_H__



Can this be split into multiple commits

yes will do that

ekanshibu · 2026-02-18T06:06:55Z

src/apps_std_imp.c

+    use_avs_list = 1;
+  }
+
+  if (use_global_list) {


this is confusing, you check for use_global_list and then pass use_avs_list to the function

removing avs specific things altogether. We didn't find any use for them

Convert ADSP library search paths from concatenated env/config strings into persistent QList-backed directory lists built at init time. This removes repeated parsing of ';' delimited path strings on every fopen call and avoids reconstructing combined search paths for each lookup. The new logic initializes global directory list during apps_std_init(). Paths from environment variables and config files are parsed once and stored as individual nodes. All file lookup APIs are updated to walk this list directly instead of reparsing a flat string. This improves efficiency, reduces string and handling complexity. Legacy behavior is preserved for custom environment variables that do not match the standard ADSP_* and DSP_* path names. Also update open_shell() to use the global list instead of constructing a temporary ";" delimited directory list. Signed-off-by: Abhinav Parihar <parihar@qti.qualcomm.com>

Previously, while parsing DSP library paths from the config YAML, we only prefixed CONFIG_BASE_DIR (/usr/share/qcom) to the first path. This caused subsequent relative paths to be left unresolved, leading to incomplete search coverage and potential library load failures. Update the parsing logic to: - Iterate over all semicolon-separated entries in dsp_lib_paths. - Prefix CONFIG_BASE_DIR to every relative path Signed-off-by: Abhinav Parihar <parihar@qti.qualcomm.com>

This patch removes Windows-style CRLF line terminators and converts the file to Unix-style LF line endings. No functional changes are made; this only normalizes formatting to match the project's coding conventions. Signed-off-by: Abhinav Parihar <parihar@qti.qualcomm.com>

quic-vkatoch · 2026-03-05T12:41:43Z

Fixes: #270

quic-parihar force-pushed the path_list_update branch 3 times, most recently from 337158e to 89d3060 Compare February 5, 2026 06:10

quic-parihar marked this pull request as ready for review February 10, 2026 06:51

quic-parihar force-pushed the path_list_update branch from 89d3060 to 431f7d8 Compare February 13, 2026 09:32

ekanshibu requested changes Feb 18, 2026

View reviewed changes

quic-parihar force-pushed the path_list_update branch from 431f7d8 to fc06976 Compare February 20, 2026 08:22

quic-parihar added 3 commits February 26, 2026 15:32

quic-parihar force-pushed the path_list_update branch from fc06976 to 7df7879 Compare February 26, 2026 10:14

		FARF(RUNTIME_RPC_LOW, "Entering %s", __func__);

		pthread_mutex_lock(&global_dirlist_mt);

Conversation

quic-parihar commented Feb 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quic-parihar Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quic-vkatoch commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

quic-parihar Feb 20, 2026 •

edited

Loading