pkg-build-pr-check: Fix repo/ref when fork PR#293
Open
simonbeaudoin0935 wants to merge 1 commit intoqualcomm:developmentfrom
Open
pkg-build-pr-check: Fix repo/ref when fork PR#293simonbeaudoin0935 wants to merge 1 commit intoqualcomm:developmentfrom
simonbeaudoin0935 wants to merge 1 commit intoqualcomm:developmentfrom
Conversation
When the PR is from a fork of the upstream project, the pr-build-pr-check workflows did not handle that correctly. Now, the proper repo and ref are forwarded to the reusable workflow_ Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
keerthi-go
approved these changes
Feb 10, 2026
ekanshibu
approved these changes
Feb 11, 2026
Contributor
|
Has this workflow been verified? Please ensure it is verified in the staging environment first and then provide the details of the verified workflow here. |
keerthi-go
approved these changes
Feb 11, 2026
Contributor
Author
This is a fix to make the pkg-build pass in the case of a pr coming from a fork. I did not know we had a staging version of this repo though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pkg-build-pr-check workflow triggers a build of the associated pkg-repo of the upstream project.
Before this fix, the workflow logic did not handle properly when the PR was from a fork of the upstream project as opposed to a branch from the repo itseld. Now, the proper repo and ref are forwarded to the reusable workflow.
Note that for this to work, the forked repo needs to be public. This should logically always be the case because our upstream repos are public to begin with, and a fork from a public repo has not choice but to be public as well.