Skip to content

refactor(preflight-checks): update workflow to use orchestrator and streamline permissions#216

Closed
sudeeshna21 wants to merge 1 commit intoqualcomm:mainfrom
sudeeshna21:preflight_checks
Closed

refactor(preflight-checks): update workflow to use orchestrator and streamline permissions#216
sudeeshna21 wants to merge 1 commit intoqualcomm:mainfrom
sudeeshna21:preflight_checks

Conversation

@sudeeshna21
Copy link
Copy Markdown

  • This PR Adds .github/workflows/qcom-preflight-checks.yml to run automated Qualcomm preflight checks on every PR and push to main. This workflow enforces project quality and compliance standards by running:

    Semgrep scan – static code analysis for security/bug patterns
    Dependency review – flags vulnerable or license-incompatible dependencies
    Repolinter check – validates repo structure against project standards
    Copyright/license check – ensures all files have proper license headers
    Commit email check – verifies commits are made with approved email addresses
    These checks help maintain code quality, security, and open-source compliance across contributions.

  • Adds .github/dependabot.yml to enable automated dependency updates via GitHub Dependabot. It is configured to:

    Monitor GitHub Actions workflow dependencies (.github/workflows/)
    Check for updates daily and automatically open PRs when newer versions of used actions are available
    This ensures CI/CD workflows always use up-to-date, patched versions of GitHub Actions, reducing exposure to known vulnerabilities in third-party actions.

…treamline permissions

Signed-off-by: sudeeshn <sudeeshn@qti.qualcomm.com>
@R-Bower
Copy link
Copy Markdown
Contributor

R-Bower commented Apr 3, 2026

@sudeeshna21

Semgrep scan – static code analysis for security/bug patterns

  • The semgrep scan takes ~10 minutes, sometimes more. I moved this from every PR to daily at 6am. I'd prefer to disable this on every PR.

@mynameistechno
Copy link
Copy Markdown

@njjetha do you know if with the updated Semgrep config (community edition) is the scan is faster than previous?

  • The semgrep scan takes ~10 minutes, sometimes more. I moved this from every PR to daily at 6am. I'd prefer to disable this on every PR.

This is more of QPSI requirement, but I think a reasonable alternative is to disable for PRs and leave on for Pushes. I will ask them about this next time we sync I.e. when a PR is merged it'll run, and as long as you're reviewing the Critical/High severity (especially before a release!), that might be ok.

That said, ideally you'd catch security vulnerabilities before they get merged.

name: Qualcomm Preflight Checks
on:
pull_request:
branches: [ main ]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@R-Bower are you sure it wasn't running on PR?

@njjetha
Copy link
Copy Markdown

njjetha commented Apr 5, 2026

@njjetha do you know if with the updated Semgrep config (community edition) is the scan is faster than previous?

  • The semgrep scan takes ~10 minutes, sometimes more. I moved this from every PR to daily at 6am. I'd prefer to disable this on every PR.

This is more of QPSI requirement, but I think a reasonable alternative is to disable for PRs and leave on for Pushes. I will ask them about this next time we sync I.e. when a PR is merged it'll run, and as long as you're reviewing the Critical/High severity (especially before a release!), that might be ok.

That said, ideally you'd catch security vulnerabilities before they get merged.

@R-Bower Previously, Semgrep was executed on the entire repository for every pull request, regardless of the files changed.
Now, Semgrep runs only on the files modified in the PR, which significantly reduces execution time and improves efficiency.
Once the changes are merged, Semgrep will continue to run on the complete repository as usual, unless specific files or directories are excluded using the .semgrepignore file.

Copy link
Copy Markdown

@njjetha njjetha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@R-Bower R-Bower mentioned this pull request Apr 8, 2026
@R-Bower R-Bower closed this in #222 Apr 8, 2026
@R-Bower
Copy link
Copy Markdown
Contributor

R-Bower commented Apr 8, 2026

@mynameistechno I replied here FYI.

@R-Bower
Copy link
Copy Markdown
Contributor

R-Bower commented Apr 8, 2026

@njjetha do you know if with the updated Semgrep config (community edition) is the scan is faster than previous?

  • The semgrep scan takes ~10 minutes, sometimes more. I moved this from every PR to daily at 6am. I'd prefer to disable this on every PR.

This is more of QPSI requirement, but I think a reasonable alternative is to disable for PRs and leave on for Pushes. I will ask them about this next time we sync I.e. when a PR is merged it'll run, and as long as you're reviewing the Critical/High severity (especially before a release!), that might be ok.
That said, ideally you'd catch security vulnerabilities before they get merged.

@R-Bower Previously, Semgrep was executed on the entire repository for every pull request, regardless of the files changed. Now, Semgrep runs only on the files modified in the PR, which significantly reduces execution time and improves efficiency. Once the changes are merged, Semgrep will continue to run on the complete repository as usual, unless specific files or directories are excluded using the .semgrepignore file.

This is much faster than it was before, cool. I've merged the changes from this PR in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants