readability/EAFP: update to Py 3, use specific exception, add race condition note #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndition note Add a note about the non-EAFP example code also having a potential race condition (which is one of the reasons why the EAFP style is preferred). Update best practice code to catch the specific FileNotFoundError (new in Python 3.3), instead of the overly broad OSError. (Add note about using OSError in Python 2, but caution that it may be too broad.) Update glossary link to point to Python 3 docs, for good measure.
|
Related: #125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note about the non-EAFP example code also having a potential race
condition (which is one of the reasons why the EAFP style is preferred).
Update best practice code to catch the specific FileNotFoundError (new
in Python 3.3), instead of the overly broad OSError. (Add note about
using OSError in Python 2, but caution that it may be too broad.)
Update glossary link to point to Python 3 docs, for good measure.