-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nondeterminacy in Circuit.insert (simplified) #7043
Open
daxfohl
wants to merge
11
commits into
quantumlib:main
Choose a base branch
from
daxfohl:circuit-insert-alt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7043 +/- ##
==========================================
- Coverage 98.17% 98.17% -0.01%
==========================================
Files 1087 1087
Lines 94722 94784 +62
==========================================
+ Hits 92992 93052 +60
- Misses 1730 1732 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6997 was a PR to fix all edge cases of #6986, but the behavior change was significant enough to be concerning. This PR replaces it with the minimum changes to fix only those edge cases that are outright bugs, without breaking any existing tests or causing possible behavior changes to 'oddities'.
Fixes #6711, and fixes #6986 edge cases that caused the bug due to order dependency:
test_3
will now produce a result equal to that oftest_4
, andtest_5
output will now equal that oftest_6
. Also fixes the bugtest_2
where EARLIEST is not performed. The behaviors intest_1
andtest_7
will remain as-is for now, and we can decide later whether we want to change those behaviors or not. (This PR description will close that issue; if we want to change those behaviors, open a new issue specific to them).Implementation description from #6997 still applies:
The diff from #6997 can be seen in commit 577f9c0