-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Return a single results object instead of always a list - IonQ #7285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7285 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 1108 1108
Lines 96453 96485 +32
=======================================
+ Hits 95175 95207 +32
Misses 1278 1278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -296,3 +296,28 @@ def test_service_remote_host_default(): | |||
def test_service_remote_host_from_env_var_cirq_ionq_precedence(): | |||
service = ionq.Service(api_key='tomyheart') | |||
assert service.remote_host == 'http://example.com' | |||
|
|||
|
|||
def test_service_run_unwraps_single_result_list(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test for the correctness of the order of multiple results being returned?
@splch Thank you for this work! Could you let us know the status of this? For example, there was the comment from @Cynocracy to add a test, but it's not immediately clear if that was resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new run batch preserves order test covers what I was hoping for :) lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause any backwards incompatibility for programs people have already written?
@dstrain115 this is a good question. The answer is unfortunately yes, but it's attempting to revert a change in interface caused by #6652 (which made it so that jobs that previously returned a single Result were returning an Iterable of them). FWIW, I am conflicted on whether it makes sense to change back, as imo, both changes are somewhat burdensome to users. |
Is there a way to consult users (perhaps some especially major users) and ask them for their input? (I guess this is a question for @Cynocracy ) |
ionq results api can return a list of results or a single result, so this change allows for either a list or single element to be returned from the results endpoint