-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Treat classically controlled ops as non-Clifford in dynamical_decoupling
#7621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Classically controlled operations were passing `_is_clifford_op`, which led `dynamical_decoupling` to synthesize/invert through them and crash. Mark them non-Clifford for DD so they act as boundaries. Add regression test `test_classically_controlled_no_update_succeeds`. Fixes quantumlib#7617
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7621 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 1091 1091
Lines 97901 97907 +6
=======================================
+ Hits 97295 97301 +6
Misses 606 606 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Clifford op indeed should be checked with the additional condition.
|
Hi @vtomole @95-martin-orion, |
|
I've been away from Cirq too long to provide a good review - leaving this to @vtomole. |
Classically controlled operations were passing
_is_clifford_op, which leddynamical_decouplingto synthesize/invert through them and crash. Mark them non-Clifford for DD so they act as boundaries. Add regression testtest_classically_controlled_no_update_succeeds.Fixes #7617