Skip to content

Fix issues with multi-circuit size in Engine#8076

Merged
dstrain115 merged 4 commits into
quantumlib:mainfrom
dstrain115:multi_circuit_fixes
May 20, 2026
Merged

Fix issues with multi-circuit size in Engine#8076
dstrain115 merged 4 commits into
quantumlib:mainfrom
dstrain115:multi_circuit_fixes

Conversation

@dstrain115
Copy link
Copy Markdown
Collaborator

  • Fix Program.get_circuit to give more descriptive error messages.
  • Fix batch_size() to work with multiple circuits.
  • Fix get_repetitions_and_sweeps to work with multi-circuits.
  • Add get_circuits() to get all the circuits.

- Fix Program.get_circuit to give more descriptive error messages.
- Fix batch_size() to work with multiple circuits.
- Fix get_repetitions_and_sweeps to work with multi-circuits.
- Add get_circuits() to get all the circuits.
@github-actions github-actions Bot added the size: L 250< lines changed <1000 label May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.63%. Comparing base (76910aa) to head (2188810).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #8076    +/-   ##
========================================
  Coverage   99.63%   99.63%            
========================================
  Files        1110     1110            
  Lines      100067   100430   +363     
========================================
+ Hits        99705   100068   +363     
  Misses        362      362            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dstrain115 dstrain115 marked this pull request as ready for review May 15, 2026 22:32
@dstrain115 dstrain115 requested review from a team, hoisinberg, verult and wcourtney as code owners May 15, 2026 22:32
Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing inline comments.

Comment thread cirq-google/cirq_google/engine/abstract_local_job.py Outdated
Comment thread cirq-google/cirq_google/engine/abstract_local_job.py Outdated
Comment thread cirq-google/cirq_google/engine/abstract_program.py Outdated
Comment thread cirq-google/cirq_google/engine/engine_job.py Outdated
Comment thread cirq-google/cirq_google/engine/engine_job_test.py Outdated
Comment thread cirq-google/cirq_google/engine/engine_program.py Outdated
Comment thread cirq-google/cirq_google/engine/engine_program_test.py
@dstrain115 dstrain115 added this pull request to the merge queue May 20, 2026
Merged via the queue into quantumlib:main with commit bde5ffa May 20, 2026
44 checks passed
@dstrain115 dstrain115 deleted the multi_circuit_fixes branch May 20, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants