Skip to content

Fix ci-daily run on windows-2022#8082

Merged
pavoljuhas merged 3 commits into
quantumlib:mainfrom
pavoljuhas:fix-ci-daily-high-atol
May 18, 2026
Merged

Fix ci-daily run on windows-2022#8082
pavoljuhas merged 3 commits into
quantumlib:mainfrom
pavoljuhas:fix-ci-daily-high-atol

Conversation

@pavoljuhas
Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas commented May 16, 2026

Problem: The atol used in a test of sub_state_vector cannot simulate
low precision when the largest eigenvalue equals 1.

Solution: Test with imperfect_state with a small artificial errors.

For instant workflow verification.

Revert this commit before submitting the PR.
@github-actions github-actions Bot added the Size: XS <10 lines changed label May 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.63%. Comparing base (7228447) to head (38de272).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8082   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        1110     1110           
  Lines      100074   100075    +1     
=======================================
+ Hits        99712    99713    +1     
  Misses        362      362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added size: S 10< lines changed <50 and removed Size: XS <10 lines changed labels May 16, 2026
@pavoljuhas
Copy link
Copy Markdown
Collaborator Author

@pavoljuhas pavoljuhas force-pushed the fix-ci-daily-high-atol branch from ccd2530 to 1ee30c0 Compare May 18, 2026 18:18
@pavoljuhas
Copy link
Copy Markdown
Collaborator Author

Confirming successful run of ci-daily at 1ee30c0

https://github.com/quantumlib/Cirq/actions/runs/26051989759

@pavoljuhas pavoljuhas marked this pull request as ready for review May 18, 2026 18:55
@pavoljuhas pavoljuhas requested a review from a team as a code owner May 18, 2026 18:55
@pavoljuhas pavoljuhas requested review from NoureldinYosri and tanujkhattar and removed request for tanujkhattar May 18, 2026 18:55
Copy link
Copy Markdown
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pavoljuhas pavoljuhas added this pull request to the merge queue May 18, 2026
Merged via the queue into quantumlib:main with commit ccf35e6 May 18, 2026
77 of 78 checks passed
@pavoljuhas pavoljuhas deleted the fix-ci-daily-high-atol branch May 18, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants