Move most setup.py configuration and metadata into pyproject.toml
#959
+101
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modern approach is to put more things into `pyproject.toml`. This moves most things out of `setup.py`, with the exception of the native code extensions parts, and the version number. (Still to do: figure out how to move the version number too.)
mhucka
force-pushed
the
mh-more-pyproject
branch
from
4242c63 to
4823984
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modernizes the project's packaging by migrating metadata from setup.py to pyproject.toml in line with PEP 621. The changes are well-executed and correctly move dependencies, project information, and other configurations. My main feedback is to eliminate the duplication of the version string, which is currently present in both pyproject.toml and setup.py. By fetching the version from the distribution metadata within setup.py, you can make pyproject.toml the single source of truth for the version, which improves maintainability and prevents potential inconsistencies.
mhucka
changed the title
setup.py configuration and metadata into pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses deprecation warnings originating from the use of outdated
setuptoolsfunctions. I took this opportunity to modernize the package definition in accordance with current Python packaging standards (PEP 621).Key changes include:
setup.pytopyproject.toml.setup.pyfile has been simplified to only contain the logic necessary for building the C++ extensions.self.distribution.get_version()method has been replaced with a direct use of the__version__variable.py.typedmarker file is now correctly included in the package via the[tool.setuptools.package-data]configuration inpyproject.toml.This should fix #839 and also set the stage for using
pyproject.tomlto add more metadata and project configuration settings.(I used Jules to help with this.)