Skip to content

First blog about test classloading changes #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

holly-cummins
Copy link
Contributor

I've added a blog discussing the externals of the test classloading change.

I was also hoping to discuss the internals, but that's harder so I kept putting it off. We ought to publish something alongside 3.22, so I've run out of runway to write an epic blog. The discussion of internals should maybe be in its own blog, which gives more time to get "part ii - the terrifying internals" written and out.

@holly-cummins holly-cummins changed the title Add test classloading blog First blog about test classloading changes Apr 22, 2025
Copy link

github-actions bot commented Apr 22, 2025

🎊 PR Preview f060d1b has been successfully built and deployed to https://quarkus-site-pr-2287-preview.surge.sh

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@cescoffier cescoffier moved this from Todo to In Progress in WG - Test classloading Apr 23, 2025
@cescoffier cescoffier self-assigned this Apr 23, 2025
@cescoffier cescoffier self-requested a review April 23, 2025 05:25
@cescoffier cescoffier removed their assignment Apr 23, 2025
@holly-cummins
Copy link
Contributor Author

Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good write up - added a few clarifying suggestions but good stuff!

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added a few comments, nothing serious.

@holly-cummins holly-cummins force-pushed the test-classloading-blog branch from 14e0126 to 310f649 Compare April 24, 2025 08:53
@holly-cummins
Copy link
Contributor Author

I think I've done all your suggestions, @cescoffier, except the rework of that introductory paragraph, where I can't come up with something that flows well. I didn't do an admonition for augmentation, just a link, because I didn't want to interrupt the bulleted flow.

Here it is with the admonition, but I think it distracts from the more important content. WDYT, @cescoffier?
image

@cescoffier
Copy link
Member

Agreed, the admonition is too prominent. It's where I would love to have "side notes" - link it is.

@maxandersen
Copy link
Member

mark as approved based on the issues i commented on is fixed. let you decide when to merge after admonition fixed.

@holly-cummins holly-cummins force-pushed the test-classloading-blog branch from 8aa2d09 to b3a7ef7 Compare April 24, 2025 14:32
@holly-cummins
Copy link
Contributor Author

I've removed the admonition and squashed. I don't know if it's best to put this out to coincide with 3.22 (yesterday) or 3.22 platform (next week).

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I would postpone the publication after the 3.22 platform release announcement, maybe just after it. But, no strong opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants