Skip to content

Add Dense property to QCard #17502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Add Dense property to QCard #17502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52a31ea
add background size property to uploader component
jrking4 Sep 6, 2024
83ec5e6
Merge branch 'dev' of https://github.com/jrking4/quasar into dev
jrking4 Sep 6, 2024
3c2f803
Merge branch 'quasarframework:dev' into dev
jrking4 Sep 6, 2024
3109e5b
add dense property to QCard
jrking4 Sep 9, 2024
ee48416
Merge branch 'dev' of https://github.com/jrking4/quasar into dev
jrking4 Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ui/src/components/card/QCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export default createComponent({
default: 'div'
},

dense: Boolean,
square: Boolean,
flat: Boolean,
bordered: Boolean
Expand All @@ -28,6 +29,7 @@ export default createComponent({
const classes = computed(() =>
'q-card'
+ (isDark.value === true ? ' q-card--dark q-dark' : '')
+ (props.dense === true ? ' q-card--dense' : '')
+ (props.bordered === true ? ' q-card--bordered' : '')
+ (props.square === true ? ' q-card--square no-border-radius' : '')
+ (props.flat === true ? ' q-card--flat no-shadow' : '')
Expand Down
4 changes: 4 additions & 0 deletions ui/src/components/card/QCard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
"extends": "bordered"
},

"dense": {
"extends": "dense"
},

"tag": {
"extends": "tag",
"default": "'div'",
Expand Down
3 changes: 3 additions & 0 deletions ui/src/components/card/QCard.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@
&--vert
padding: 16px

.q-card--dense &--vert
padding: 2px 16px

Comment on lines +42 to +44
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify it by doing this:

Suggested change
.q-card--dense &--vert
padding: 2px 16px
&--dense &--vert
padding: 2px 16px

&--horiz
> div,
> img
Expand Down