Skip to content

refactor: use standalone components #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

jeremy-eychenne
Copy link
Collaborator

Closes #305

@jeremy-eychenne jeremy-eychenne force-pushed the 305-use-standalone-components branch 5 times, most recently from a41963d to 1e2cd6c Compare May 9, 2025 15:16
],
],
standalone: true,
imports: [AngularOpenlayersModule],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why all demos still using AngularOpenlayersModule instead of provideNgxOpenlayers ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeremy-eychenne jeremy-eychenne force-pushed the 305-use-standalone-components branch from 1e2cd6c to db15ea8 Compare May 19, 2025 09:05
@jeremy-eychenne jeremy-eychenne force-pushed the 305-use-standalone-components branch from db15ea8 to b0cf692 Compare May 19, 2025 09:18
@Dji75
Copy link

Dji75 commented May 19, 2025

LGTM

@jeremy-eychenne jeremy-eychenne marked this pull request as ready for review May 19, 2025 09:29
@jeremy-eychenne jeremy-eychenne merged commit c4da28e into next May 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants