ES2015: Modules: export declarations (partial)#80
Closed
gasi wants to merge 10 commits intoquintenkasteel:new-astfrom
Closed
ES2015: Modules: export declarations (partial)#80gasi wants to merge 10 commits intoquintenkasteel:new-astfrom
export declarations (partial)#80gasi wants to merge 10 commits intoquintenkasteel:new-astfrom
Conversation
This fixes the messaging as LHS is actual and RHS expected test result.
8 tasks
3f96dc0 to
6598e83
Compare
6598e83 to
25cf749
Compare
Collaborator
|
Manually squashed and merged. Thanks! |
This was referenced Nov 21, 2018
Contributor
Author
|
@erikd Just got back from vacation. Thanks for the review and merging 👍 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #79.
After reading the spec more and approaches such as Shift AST, I concluded we want to introduce
Moduleas a top-level abstraction next toProgram(and later replaceProgramwithScript):— https://blog.shapesecurity.com/2015/01/06/a-technical-comparison-of-the-shift-and-spidermonkey-ast-formats/
This makes it less likely for invalid programs to inhabit the AST, e.g.
exportin aProgram(later:Script). I like their approach:I found out about Shift AST in connection with this project somewhere (can’t find the reference anymore). What’s the approach for the new AST? Would it make sense to follow Shift AST spec if possible? Might make for some nice potential interop and learning opportunities.
Update: Found the reference: #41 (comment)