Registry #28
Merged
Registry #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
registry.jsonfile only contained information on imported catalogs. With this PR,registry.jsonalso contains information about installed extensions.This was done because on Windows, it is not possible to delete a jar when it was previously loaded by a class loader. This means that removing an extension was not possible on Windows.
With this PR, when removing an extension, an attempt is made to remove the jars, but the whole operation doesn't fail if the jars cannot be deleted. This doesn't cause any issue because now it is
registry.jsonthat contains the information on whether or not an extension is installed, not the extension jars.When an extension is uninstalled or updated, a dialog now informs the user that the application should be restarted in order to see the changes, since jars cannot be unloaded.