Skip to content

fix(styled): modal data-open data-closed #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

serbyxp
Copy link

@serbyxp serbyxp commented Feb 24, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Old data-state=“open” data-state=“closed” for accordion animations in global.css, and for styled Modal in-lined tailwind classes.

Updated documentation to reflect changes in Modal.css

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • [?] Added new tests to cover the fix / functionality

I have read the CLA Document and I hereby sign the CLA

…ailwind utilities and inline css for styled modal and accordian. Reflected changes in docs
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 36b3cfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
qwik-ui Patch
@qwik-ui/styled Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@maiieul
Copy link
Contributor

maiieul commented May 21, 2025

LGTM 👌 Thanks @serbyxp! I just need you to approve the CLA and I can merge the PR 🙌

@maiieul maiieul changed the title FIX, DOCS fix(styled): modal data-open data-closed May 23, 2025
@serbyxp
Copy link
Author

serbyxp commented May 23, 2025

I have read the CLA Document and I hereby sign the CLA

@serbyxp
Copy link
Author

serbyxp commented May 23, 2025

LGTM 👌 Thanks @serbyxp! I just need you to approve the CLA and I can merge the PR 🙌

I have read the CLA Document and I hereby sign the CLA

Copy link
Author

@serbyxp serbyxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants