chore(headless): deprecate tabs shorthand api #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25b760c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
maiieul
changed the title
|
I want to do a release before merging this |
maiieul
commented
Oct 19, 2024
| // The consumer must provide a key if they change the order | ||
| const matchedTabComponent = tabComponents[panelIndex]; | ||
| const tabIdFromTabMaybe = | ||
| (matchedTabComponent?.props as TabProps).tabId || matchedTabComponent?.key; | ||
| const tabId: string = tabIdFromTabMaybe || child.key || `${panelIndex}`; | ||
|
|
||
| if (label) { |
There was a problem hiding this comment.
add comments instead of removing for deprecation
|
Is this still going to be merged? |
maiieul
force-pushed
the
deprecate-headless-tabs-short-api
branch
from
121aa73 to
25b760c
Compare
|
@thejackshelton I thought we merged this a looong time ago 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Why is it needed?
Checklist:
pnpm changeand documented my changes