Update varchar() to count bytes not chars
#961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #960
This PR changes
varchar()to measure the input length in bytes (nchar(x, type = "bytes")) rather than characters.This matches SQL Server’s definition of
VARCHAR(n)as the number of bytes, and prevents truncation when inserting multibyte UTF-8 strings.Counting bytes instead of characters should not adversely affect other database backends.
Includes a minimal test verifying the multibyte case.