Guard PluginLoader directory scan against enumeration exceptions#85
Open
yolkin-games wants to merge 1 commit into
Open
Guard PluginLoader directory scan against enumeration exceptions#85yolkin-games wants to merge 1 commit into
yolkin-games wants to merge 1 commit into
Conversation
rabanti-github
added
the
pending
Owner
|
Hello, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadReferencedAssemblies calls Directory.GetFiles(AppDomain.CurrentDomain.
BaseDirectory, "*.dll") unguarded. Because this runs from WorkbookReader's
static constructor, any throw (e.g. IOException 'The parameter is incorrect'
when BaseDirectory holds an entry the native enumerator can't stat — seen when
the host base dir is the Unity 6000.5.x editor folder) surfaces as a
TypeInitializationException and permanently disables the reader for the whole
AppDomain.
Wrap the enumeration in try/catch and fall back to the Phase 1 (loaded-assembly)
registration result, mirroring the per-path try/catch already in the load loop.