Refining producer exception logging and bubbling#265
Merged
Conversation
…n exception instance
…ion logging to debug level (since the exceptions are raised, logging as an exception pollutes logs when these exceptions are caught downstream)
Gsantomaggio
approved these changes
Jan 26, 2026
Gsantomaggio
approved these changes
Jan 27, 2026
Member
|
Thank you @dbotwinick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed exception logging in _get_or_create_publisher() to use debug for reraised exceptions (particularly relevant for StreamDoesNotExist) because it was polluting logs when the exception is caught and handled by user code outside of rstream. Also changed schema check_response_code() to raise an exception instance instead of the raw type/class.