Update apheleia-indent-lisp-buffer to respect local variables
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for any local values for `indent-line-function`, `lisp-indent-function` to be carried over when formatting. Additionally, added `indent-tabs-mode` in order to prevent adding tabs when unwanted.
|
Yeah, that makes sense. We should be enabling the major mode before setting the local variables. I think this just needs a changelog entry, no need to update the README as the new behavior is what a user would intuitively expect to happen. |
|
I put it under bugs fixed if that works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues using apheleia while contributing to a project
that works with
indent-tabs-modedisabled. This led to this slightmodification of
apheleia-indent-lisp-bufferThis allows for any local values for
indent-line-function,lisp-indent-functionto be carried over whenformatting. Additionally, added
indent-tabs-modein order toprevent adding tabs when unwanted.
If there is any additional documentation you would like me to provide,
let me know and I can update.