Fix patches moving a line to the top of the file. #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCS patches containing a 'a0' instruction are not handled properly. This commit fixes the handling of 'a0' instructions and adds an integration test that fails otherwise. Fixes radian-software#299.
raxod502
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
Beautiful! Thank you! I'm glad the framework I started was easy enough to extend.
You mentioned that you had trouble running the tests on macOS - if you feel like it, go ahead and file another issue with the error message from that, I suspect it's easy to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCS patches containing a 'a0' instruction are not handled properly.
This pull request fixes the handling of 'a0' instructions and adds an integration test that fails otherwise.
Fixes #299.