docs: require signed commits#11873
Open
Copilot wants to merge 5 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/radius-project/radius/sessions/c9b37b66-e362-434e-8783-7d523ebf5da6 Co-authored-by: brooke-hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Agent-Logs-Url: https://github.com/radius-project/radius/sessions/43578fa1-b891-4de7-9e28-c810db816bf9 Co-authored-by: brooke-hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Agent-Logs-Url: https://github.com/radius-project/radius/sessions/3db4b784-39c5-4544-94cf-9f9389c43ec6 Co-authored-by: brooke-hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
brooke-hamilton
May 13, 2026 14:00
View session
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the contributor documentation to explicitly require cryptographic commit signing (separate from DCO sign-off), centralizing the guidance in the “first commit” guide and linking to it from the PR guidelines to avoid duplicated instructions.
Changes:
- Add a new “Signing your commits” section to the first-commit PR-creation guide, including supported signature types and links to GitHub’s official docs.
- Add a short pointer section in the pull request contributing guide that links to the canonical signing instructions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/contributing/contributing-pull-requests/README.md | Adds a “Signing your commits” section that links to the canonical guidance. |
| docs/contributing/contributing-code/contributing-code-first-commit/first-commit-06-creating-a-pr/index.md | Adds the canonical commit-signing guidance, references, and a git config one-liner. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor docs only mentioned the DCO
Signed-off-byline and never told contributors to cryptographically sign commits. Adds the missing guidance, written once and linked from related docs.first-commit-06-creating-a-pr/index.md: New "Signing your commits" section — calls out that signing is separate fromSigned-off-by, lists the three supported formats (GPG / SSH / S/MIME), links to the four relevant GitHub docs, and shows thegit config --global commit.gpgsign trueone-liner.contributing-pull-requests/README.md: "Signing your commits" section is a one-line pointer to the canonical section above — no duplicated prose.Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
eng/design-notes/in this repository, if new APIs are being introduced.