Add resource type sync step to the release process#11912
Open
kachawla wants to merge 9 commits into
Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Member
Author
lakshmimsft
reviewed
May 15, 2026
| ### Step 3: Update default resource types | ||
|
|
||
| Ensure the default resource type manifests are up to date with the latest `resource-types-contrib` definitions: | ||
|
|
Contributor
There was a problem hiding this comment.
checking: this is to be run in resource-types-contrib repo or radius? maybe we can make that explicit.
Member
Author
There was a problem hiding this comment.
Good catch - this runs in the radius repo. Updated to be explicit.
lakshmimsft
reviewed
May 15, 2026
| 1. **Fix forward**: Correct the manifest in `resource-types-contrib`, merge the fix, then re-run `make update-resource-types`. | ||
| 2. **Pin to last known good version**: Revert the `go.mod` change to keep the previous `resource-types-contrib` version and run `make sync-resource-types` to restore the matching manifests. | ||
|
|
||
| Open a separate PR with the updated `go.mod`, `go.sum`, and manifest files. Merge it before proceeding to the `versions.yaml` update. |
Contributor
There was a problem hiding this comment.
pls specify we merge this into 'main' branch and which repo?
Member
Author
There was a problem hiding this comment.
It's a PR targeting main in radius. Updated to clarify. Thanks for reviewing
kachawla
commented
May 15, 2026
Replace manually-maintained per-namespace manifest files with per-type manifest files copied from resource-types-contrib. This eliminates schema drift by making resource-types-contrib the single source of truth for resource type schemas that ship as defaults in Radius. File layout change: Previously, built-in-providers/ contained one YAML file per namespace (e.g. radius_compute.yaml with containers, routes, and persistentVolumes all in one file). Now each resource type has its own file (containers.yaml, routes.yaml, persistentVolumes.yaml, etc.), matching the per-type file layout in resource-types-contrib. This makes it straightforward to map defaults.yaml entries to files and keeps diffs scoped to the type that changed. Changes: - Add deploy/manifest/defaults.yaml listing default resource types - Add build/resource-types.mk with update-resource-types and sync-resource-types Makefile targets - Add pkg/resourcetypescontrib/import.go with a blank import to keep resource-types-contrib in go.mod across go mod tidy - Add go.mod dependency on resource-types-contrib pinned to v0.0.0-20260515162318-067b29d71eb8 - Copy per-type manifest files from resource-types-contrib into both dev/ and self-hosted/ directories - Remove old per-namespace files (radius_compute.yaml, radius_data.yaml, radius_security.yaml) from both directories - Add .github/workflows/verify-resource-types.yaml for CI drift detection - Add integration test for no-location manifest registration The copied manifests have no 'location' field, so UCP routes requests via DefaultDownstreamEndpoint (dynamic-rp), matching existing behavior. Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Shell comments (#) inside multi-line backslash-continued recipe blocks break the continuation chain, causing 'Syntax error: end of file unexpected' in CI. Move all inline comments to standalone @# lines before the shell block they describe. Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Verify the global location resource is created with no address property, confirming UCP will use DefaultDownstreamEndpoint for routing. Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
kachawla
force-pushed
the
kachawla/automate-resource-types
branch
from
5a5922a to
e2af82c
Compare
Add Step 3 (Update default resource types) to the RC release process, instructing release engineers to run 'make update-resource-types' before cutting each release. This ensures the latest resource type schemas from resource-types-contrib are included. Includes guidance on handling schema validation failures: either fix the manifest upstream and re-bump, or pin to the last known good version. The resource type update should be done in a separate PR that is merged before the versions.yaml change. Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
kachawla
force-pushed
the
kachawla/release-process-resource-types
branch
from
01dcf2d to
0cd6837
Compare
lakshmimsft
previously approved these changes
May 15, 2026
nithyatsu
approved these changes
May 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds release-process documentation for syncing default resource type manifests before updating versions.yaml, aligning RC release steps with the automated resource type registration workflow.
Changes:
- Adds a new RC release step to run
make update-resource-types. - Documents recovery options for failed updates or schema validation issues.
- Renumbers later RC release steps and updates related cross-references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a new step to the RC release process documenting when and how to run
make update-resource-typesbefore each release.This is PR 3 from the automated default resource type registration design.
Changes
docs/contributing/contributing-releases/README.mdresource-types-contrib, merge, and re-runmake update-resource-typesgo.modchange and runmake sync-resource-typesto restore matching manifestsDepends on