Skip to content

Conversation

gincsai
Copy link
Contributor

@gincsai gincsai commented Oct 13, 2025

On the demo page, the Awards and WorkStatus DoesNotContain filtering shows invalid data. (Eg: does not countains Award3, Award4)
https://blazor.radzen.com/datagrid-filtervalue-template?theme=material3

On the demo page the Awars and WorkStatus does not cotains filtering shows invalid data.
https://blazor.radzen.com/datagrid-filtervalue-template?theme=material3
@enchev
Copy link
Collaborator

enchev commented Oct 13, 2025

This change will brake In/NotIn

@gincsai
Copy link
Contributor Author

gincsai commented Oct 13, 2025

How? The modified code will not run for In / NotIn as it was in the original code.
Is there any test that fails after this modification?

@enchev
Copy link
Collaborator

enchev commented Oct 14, 2025

You are right, there isn't test that fails - feel free to add such.

@gincsai
Copy link
Contributor Author

gincsai commented Oct 14, 2025

The IN operator is correct, but I think the NOTIN should return those items that were not in the IN result.
All items = IN + NOTIN
Current IN -> list.Any( x => filter.Contains(x))
Current NOTIN -> list.Any( x => !filter.Contains(x))
My code -> list.All(x => !filter.Contains(x)) - These items were not in the IN result.

But this is a breaking change.
Do you see any option to pass a parameter to the filtering, specifying how to handle 'IN' and 'NOT IN'? I mean, use Any() or All()?

@enchev
Copy link
Collaborator

enchev commented Oct 15, 2025

I've added yesterday various tests realted to filtering. Try to rebase your branch to the master branch and check what's failing after your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants