-
-
Notifications
You must be signed in to change notification settings - Fork 84
feat: add letscloud.io partnership #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdded a Sponsors section to the README, appended a CTA button under the sponsor marquee component, and updated the sponsors JSON with a new sponsor, refined HostUp details, and a GitHub handle rename. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (1)
93-99: Sponsors section looks good; consider local assets and alt text tweaksThe new Sponsors block reads well and is consistent with the sponsor data. To harden it a bit:
- Consider hosting the logos in-repo (e.g., under
docs/public/sponsor/orassets/) instead of hotlinkinggstatic/- Optionally align
alttext to the brand names (“Lets Cloud”, “HostUp”) for slightly better accessibility and screen‑reader output.docs/.vitepress/components/SponsorsMarquee.vue (1)
39-43: CTA integration under marquee looks consistent; double‑check/sponsor/target and statesThe new “View All Sponsors & Partnerships” CTA fits nicely with the existing design, and the styling is consistent with the brand colors and responsive rules.
Two small things to verify:
- The
/sponsor/route (or page) is present and deployed in the docs site so this CTA doesn’t 404.- You’re okay with the CTA showing even when sponsors are in loading/error state (since it’s outside the
v-elseblock). If you want it hidden in those cases, it should move inside the successful‑load branch.Also applies to: 359-404
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README.md(1 hunks)docs/.vitepress/components/SponsorsMarquee.vue(2 hunks)docs/public/sponsor/sponsors.json(2 hunks)
🔇 Additional comments (1)
docs/public/sponsor/sponsors.json (1)
2-10: Sponsor data shape matches UI expectations; confirm copy and links with partnersThe new Lets Cloud entry and the updated
@zhravanrecord look structurally correct and compatible with the marquee component (name/avatar/type/website/github are all present and consistent).Given this is outward‑facing partnership content, it’s worth double‑checking:
- The Lets Cloud offer text (
$300 credit, 1‑click install, complimentary VPS) matches the actual agreed‑upon terms.- The GitHub URLs (
letscloud-community,zhravan) and websites are the ones the sponsors expect to be highlighted.Also applies to: 20-25
Issue
Link to related issue(s):
Description
Short summary of what this PR changes or introduces.
Scope of Change
Select all applicable areas impacted by this PR:
Screenshot / Video / GIF (if applicable)
Attach or embed screenshots, screen recordings, or GIFs demonstrating the feature or fix.
Related PRs (if any)
Link any related or dependent PRs across repos.
Additional Notes for Reviewers (optional)
Anything reviewers should know before testing or merging (e.g., environment variables, setup steps).
Developer Checklist
To be completed by the developer who raised the PR.
Reviewer Checklist
To be completed by the reviewer before merge.
Summary by CodeRabbit
New Features
Documentation / Content
✏️ Tip: You can customize this high-level summary in your review settings.