Allow use of secure session only #199
Merged
+56
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmandke
force-pushed
the
optional-insecure-session-fallback
branch
from
23ccf4f to
0eb5495
Compare
stevenharman
force-pushed
the
optional-insecure-session-fallback
branch
2 times, most recently
from
0db1d35 to
7743696
Compare
|
👋 Hello! Anything we can do to help this one along? We'd love to get back on the mainline version. Thank you. |
|
😄 bump! Any hopes of getting this merged? |
stevenharman
force-pushed
the
optional-insecure-session-fallback
branch
2 times, most recently
from
11b5406 to
ba695f3
Compare
stevenharman
force-pushed
the
optional-insecure-session-fallback
branch
2 times, most recently
from
18cd1ee to
e9fed90
Compare
This change allows the disabling of fallback used to access old, insecure sessions, and rewrite them as secure sessions. The fallback was originally added as part of the mitigation of CVE-2019-25025 several years back. However, this fallback mechanism was added over 5 years ago. In many cases, or at least in our case, the expiry on old, insecure, sessions has long since passed. We'd like the ability to disable the fallback entirely as it will never be a valid path for us. See: rails#151 Also, we had to improve our patch for `ActionDispatch::Assertions::RoutingAssertions::WithIntegrationRouting` to handle middleware correctly. This is the same implementation as was added in Rails 8.0. See: rails/rails#54705
stevenharman
force-pushed
the
optional-insecure-session-fallback
branch
from
e9fed90 to
44e4b7e
Compare
|
@byroot I had to further update the patch for |
Not that I know off. I'm also quite surprised such complexity is needed. I think it might be because gems like this one are expected to have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the disabling of fallback used to access old, insecure sessions, and rewrite them as secure sessions. The fallback was originally added as part of the mitigation of CVE-2019-25025 several years back.
Motivation
This fallback mechanism was added 4 years ago. In many cases, or at least in our case, the expiry on old, insecure, sessions has long since passed. We'd like the ability to disable the fallback entirely as it will never be a valid path for us.