Skip to content

fix: show additional mise.toml tools in output summary - #496

Open
manasa-bhagwat wants to merge 2 commits into
railwayapp:mainfrom
manasa-bhagwat:fix/419-mise-extra-tools-output
Open

fix: show additional mise.toml tools in output summary#496
manasa-bhagwat wants to merge 2 commits into
railwayapp:mainfrom
manasa-bhagwat:fix/419-mise-extra-tools-output

Conversation

@manasa-bhagwat

@manasa-bhagwat manasa-bhagwat commented Mar 10, 2026

Copy link
Copy Markdown

This PR addresses #419, adds test coverage for the new output behavior, and passes mise run check and mise run test.

Summary

  • Add an informational output line when additional tools are detected from mise.toml beyond provider-resolved packages.
  • Show up to 3 additional tool names and append , etc. when there are more.
  • Keep the existing Packages table focused on resolved/provider packages.

Reproduction (before)

  • Ran:
    • mise run cli -- --verbose build --show-plan examples/mise-config
  • examples/mise-config/mise.toml defines node, bun, python, go.
  • Output only listed node and bun in Packages, with no mention of extra tools.

After

  • Output now includes:
    • Also installing additional tools from mise.toml: go, python
list packages

Test Plan

  • mise run check
  • mise run test
  • Manual validation:
    • mise run cli -- --verbose build --show-plan examples/mise-config
    • mise run cli -- --verbose info examples/mise-config

Signed-off-by: manasa <manasa.bhagwat.work@gmail.com>

@iloveitaly iloveitaly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! Left some comments. I love the idea here and would like to get this merged!

Comment thread core/core.go Outdated
Comment thread core/core.go Outdated
Comment thread core/core.go Outdated
Comment thread core/core.go Outdated
Signed-off-by: manasa <manasa.bhagwat.work@gmail.com>
@manasa-bhagwat

Copy link
Copy Markdown
Author

@iloveitaly I’ve addressed the review feedback and updated the evidence screenshot.

Could you please take another look when you have a moment?.

@iloveitaly iloveitaly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to display every package in mise.toml. It could get a little crazy and most folks who have a lot in their mise config know it's there, so it doesn't add much value to display it.

I think what we should do here is:

  1. Limit the number of mise packages we display to 5
  2. This is display-only logic, so we if we can keep it contained to a single method which makes it clear this only for displaying more info to users that would be great.

Version string
Source string
Version string
RequestedVersion string

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants