Preserve exact Gradle wrapper versions - #560
Open
radiantjade wants to merge 1 commit into
Open
Conversation
Railpack should pass the version pinned in gradle-wrapper.properties through to mise instead of truncating it to the major version. Major-only resolution can select newer milestones or previews that the project did not request. Constraint: Gradle wrapper distribution URLs are the authoritative version source for Gradle wrapper projects. Rejected: Keep major-only parsing | allows mise latest-major resolution to drift to prerelease versions. Confidence: high Scope-risk: narrow Tested: go test ./core/providers/java Tested: go test ./core -run 'TestGenerateBuildPlanForExamples/java-gradle' Tested: git diff --cached --check
iloveitaly
requested changes
May 30, 2026
iloveitaly
left a comment
iloveitaly
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the contribution! Would it be possible to add an example project (examples/, we have something for gradle in there already) which covers this logic?
We are a big fan of additional integration tests (via example projects) for this sort of thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554.
This passes the full Gradle version pinned in
gradle/wrapper/gradle-wrapper.propertiesthrough to mise instead of truncating it to the major version. That avoidslatest <major>resolution selecting newer milestones or previews when the wrapper is pinned to an exact stable version.The wrapper URL parser now captures versions from
gradle-<version>-bin.zipandgradle-<version>-all.zip, including patch and prerelease suffixes.Verification:
go test ./core/providers/javago test ./core -run 'TestGenerateBuildPlanForExamples/java-gradle'\n-git diff --cached --check