feat(build): support build networking flags for exec steps - #630
Open
iloveitaly wants to merge 1 commit into
Open
feat(build): support build networking flags for exec steps#630iloveitaly wants to merge 1 commit into
iloveitaly wants to merge 1 commit into
Conversation
* Add support for `--network` and `--add-host` flags by parsing frontend options compatible with the Dockerfile frontend (e.g., `force-network-mode` and `add-hosts`). * Apply these network configurations to plan exec steps, ensuring build-time network access matches standard Dockerfile behavior. * Update documentation to include build networking references and usage examples for both Docker and BuildKit. Generated-by: aiautocommit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
docker buildx --networkand--add-hostwere ignored by the Railpack frontend, so build-time network access did not match Dockerfile behavior.Description
Parse the same dockerui frontend opts as the Dockerfile frontend (
force-network-mode,add-hosts) and apply them to plan exec steps viallb.Network/llb.AddExtraHost. Document the Docker and BuildKit usage.Test
network_opts_test.go)convert_network_test.go)Links
Fixes #145