Bump versions to 5 and update metaboards mapping#84
Conversation
WalkthroughThis PR updates registry commit hash references to a new versioned base, bumps version numbers from 4 to 5 across settings.yaml and all strategy files, and restructures metaboards configuration into structured objects with address and url fields alongside orderbook configuration augmentation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@registry`:
- Around line 1-9: The registry file references raw.githubusercontent.com URLs
pinned to commit 1874f216cf22c469efc5ae5a4126d9d5a8602171 which won’t exist on
main after merge; update all occurrences of that commit SHA in the registry
entries (the raw.githubusercontent.com URLs for settings.yaml and each .rain
file: fixed-limit, auction-dca, grid, dynamic-spread, canary, claims,
fixed-spread, folio) to the final merge commit SHA that will be on main (or
switch the URLs to a SHA already present on main) so the links won’t 404 after
merging.
| https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/settings.yaml | ||
| fixed-limit https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/src/fixed-limit.rain | ||
| auction-dca https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/src/auction-dca.rain | ||
| grid https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/src/grid.rain | ||
| dynamic-spread https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/src/dynamic-spread.rain | ||
| canary https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/src/canary.rain | ||
| claims https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/src/claims.rain | ||
| fixed-spread https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/src/fixed-spread.rain | ||
| folio https://raw.githubusercontent.com/rainlanguage/rain.strategies/1874f216cf22c469efc5ae5a4126d9d5a8602171/src/folio.rain |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if the commit exists in the local repository
git rev-parse --verify 1874f216cf22c469efc5ae5a4126d9d5a8602171 2>&1
# Show recent commits to understand the commit history
echo "Recent commits:"
git log --oneline -10
# Check current branch
echo "Current branch:"
git rev-parse --abbrev-ref HEAD
# Check if this commit is on main
echo "Is commit on main?"
git log main --oneline | grep 1874f216cf22c469efc5ae5a4126d9d5a8602171 || echo "Not found on main"Repository: rainlanguage/rain.strategies
Length of output: 222
🏁 Script executed:
#!/bin/bash
# Find the PR number from context
echo "Looking for PR information..."
git log --all --oneline | grep -i registry | head -20
# Check if there's documentation about merge process
find . -name "*.md" -o -name "*.txt" -o -name ".github" -type d | head -5
# Check GitHub Actions or CI configuration
ls -la .github/workflows/ 2>/dev/null || echo "No workflows directory"
# See if there's a script or note about updating registry
find . -type f -name "*.sh" -o -name "*registry*" | grep -v ".git" | head -10Repository: rainlanguage/rain.strategies
Length of output: 744
🏁 Script executed:
#!/bin/bash
# Check README for registry management documentation
echo "=== README content (first 100 lines) ==="
head -100 README.md
echo ""
echo "=== Check git merge strategy hints ==="
# Check if there's a merge base between current branch and main
git merge-base --is-ancestor 1874f216cf22c469efc5ae5a4126d9d5a8602171 main 2>&1 && echo "Commit is ancestor of main" || echo "Commit is NOT ancestor of main"
# Look at the actual merge commit to see merge strategy
echo ""
echo "=== Recent merge commits ==="
git log main --grep="registry" --oneline | head -5Repository: rainlanguage/rain.strategies
Length of output: 398
Registry commit SHA will not be reachable on main after merge—update required before or after merge.
The registry references commit 1874f216cf22c469efc5ae5a4126d9d5a8602171, which exists only on this PR branch and is not an ancestor of main. After merge, these raw.githubusercontent.com URLs will 404. Either update the registry entries with the final merge commit SHA after the PR is merged, or use a commit SHA that will exist on main before merge.
🤖 Prompt for AI Agents
In `@registry` around lines 1 - 9, The registry file references
raw.githubusercontent.com URLs pinned to commit
1874f216cf22c469efc5ae5a4126d9d5a8602171 which won’t exist on main after merge;
update all occurrences of that commit SHA in the registry entries (the
raw.githubusercontent.com URLs for settings.yaml and each .rain file:
fixed-limit, auction-dca, grid, dynamic-spread, canary, claims, fixed-spread,
folio) to the final merge commit SHA that will be on main (or switch the URLs to
a SHA already present on main) so the links won’t 404 after merging.
Motivation
Version bump for settings and all strategy files, along with updating the metaboards mapping to the new format that supports address and url fields.
Solution
settings.yamland all 8.rainstrategy filesaddressandurlfields instead of a plain URL string0x59401c9302e79eb8ac6aea659b8b3ae475715e86Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit