Skip to content

Conversation

@ilyaplot
Copy link

@ilyaplot ilyaplot commented May 4, 2023

Added methods for creating 7 and 8 versions of UUID to the UuidFactoryInterface

Description

Added methods for creating 7 and 8 versions of UUID to the UuidFactoryInterface

Motivation and context

To work with the factory through the interface, you need methods for generating UUID, which are implemented in the factory.

How has this been tested?

This change does not require further testing. If the description of the methods in the interface is incorrect, tests using the implementation of the interface will fail.

Types of changes

  • New feature (non-breaking change which adds functionality)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@ilyaplot ilyaplot requested a review from ramsey as a code owner May 4, 2023 14:11
@ramsey
Copy link
Owner

ramsey commented May 4, 2023

Thanks! This wasn't an oversight. I didn't add them on purpose because releasing this as part of the 4.x series would be a major BC break (since we're adding to an interface).

This will have to wait until the next major version (5.x).

@ilyaplot
Copy link
Author

ilyaplot commented May 4, 2023

Ok, we will be waiting.

@mougrim
Copy link

mougrim commented May 29, 2024

Hi all!
Hope you are well.

@ramsey, when approx 5 version will be released?

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.83%. Comparing base (c72360e) to head (48ac45e).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x     #505      +/-   ##
============================================
- Coverage     95.16%   94.83%   -0.33%     
  Complexity      584      584              
============================================
  Files            70       70              
  Lines          1840     1840              
============================================
- Hits           1751     1745       -6     
- Misses           89       95       +6     

see 1 file with indirect coverage changes

@MGatner
Copy link

MGatner commented Aug 10, 2025

Hi, bumping this thread because my container uses the interface which doesn't include the v7 method:

Call to an undefined method Ramsey\Uuid\UuidFactoryInterface::uuid7().

I'm happy to help get this change ready for release, but mostly curious about where it falls on the roadmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants