[5.x] Upgrade brick/math to support versions ^0.14.2–^0.17#634
Open
balu-lt wants to merge 2 commits intoramsey:5.xfrom
Open
[5.x] Upgrade brick/math to support versions ^0.14.2–^0.17#634balu-lt wants to merge 2 commits intoramsey:5.xfrom
brick/math to support versions ^0.14.2–^0.17#634balu-lt wants to merge 2 commits intoramsey:5.xfrom
Conversation
This was referenced Mar 12, 2026
brick/math to support versions ^0.14.2, ^0.15, and ^0.16brick/math to support versions ^0.14.2, ^0.15, and ^0.16
brick/math to support versions ^0.14.2, ^0.15, and ^0.16brick/math to support versions ^0.14.2–^0.17
|
@ramsey really sorry to bother you but is it possible to merge this anytime soon? There are multiple PR open for the same issue, one starting february. If you need any help please let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the
brick/mathdependency and updates the codebase to use the new rounding mode constants introduced in version 0.14.2.Key changes:
Brick\Math\RoundingModeconstants from SCREAMING_SNAKE_CASE (deprecated) to PascalCase (e.g.,HALF_UP->HalfUp).composer.jsonto requirebrick/math: ^0.14.2 || ^0.15 || ^0.16 || ^0.17.BrickMathCalculatorTestto handle variations in exception messages between differentbrick/mathversions.Ramsey\Uuid\Type\Time::toString()to ensure it returns anumeric-string, addressing a PHPStan static analysis error.Motivation and context
brick/math0.14.2 introduced PascalCase constants and deprecated the old ones. The old constants are removed in version 0.15. This update ensures the library remains compatible with current and future versions of the dependency. Additionally, it fixes a type-hinting issue reported by PHPStan in theTimeclass.How has this been tested?
vendor/bin/phpunitto ensure all functionality remains intact.composer dev:analyzeto verify the fix insrc/Type/Time.php.brick/math(0.14.2) in the CI environment.Types of changes
PR checklist