fix: try to get the nodes 3 times before failure #132
Merged
+106
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There is a part of the module which blindly reaches out to AWS for information on nodes that Rancher is deploying.
It does this to adjust the node's security groups in order to allow them to talk back to Rancher without making the Rancher node public. The blind part is the problem. We need to hit the sweet spot of after the nodes are deployed in AWS, but before the cluster generation times out waiting for the nodes to talk back. I have set the Rancher timeout to 120 minutes, it is obviously not ideal to have to wait 120 minutes to deploy a cluster, so we want to get the fastest transition we can without hitting that limit. The variables involved are things like the Rancher node latency, the AWS latency, the AWS API throttling, AWS instance deployment latency, AWS instance boot timing, cloud-init problems, etc.
Solution:
I have recently added two solutions: