Add benchmark for public and private key parsing #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/pk-parsing-bench
branch
from
f90edeb to
2390aa9
Compare
reneme
approved these changes
Mar 27, 2025
…SN.1 case For every other constructor we are willing to assume the bit length is public; this just pessimizes the case when the key is loaded from PKCS8
Historically this function made some attempts to be constant-time-ish (despite not being constant time at all), largely because it was the only implemented division algorithm. Now we have dedicated constant time division algorithms which are used for secret data; we can readily assume the inputs to vartime_divide are public.
randombit
force-pushed
the
jack/pk-parsing-bench
branch
from
2390aa9 to
bc97a9b
Compare
reneme
reviewed
Mar 28, 2025
Comment on lines
+283
to
+289
| for(size_t k = 0; k != 2; ++k) { | ||
| if(division_check_vartime(qjt, y_t0, y_t1, x_j0, x_j1, x_j2)) { | ||
| qjt--; | ||
| } else { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
The code is a bit cleaner without the upper bound
😁
Suggested change
| for(size_t k = 0; k != 2; ++k) { | |
| if(division_check_vartime(qjt, y_t0, y_t1, x_j0, x_j1, x_j2)) { | |
| qjt--; | |
| } else { | |
| break; | |
| } | |
| } | |
| for(size_t k = 0; k != 2 && ! division_check_vartime(qjt, y_t0, y_t1, x_j0, x_j1, x_j2); ++k, --gjt); | |
| BOTAN_DEBUG_ASSERT(!division_check(qjt, y_t0, y_t1, x_j0, x_j1, x_j2)); |
... I'm not sure. 😅
There was a problem hiding this comment.
I am sure that is fucking hideous :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus various optimizations driven by this