feat: add bindable togglemaximized action - #1690
Open
cantona wants to merge 1 commit into
Open
Conversation
ToggleMaximized existed as an Action variant but was never wired up: it had no action-string mapping (so config bindings couldn't reference it) and no handler. Add the "togglemaximized" parser entry, a toggle_maximize_window() that emits RioEvent::ToggleMaximized, the Act::ToggleMaximized arm, and an application handler that flips set_maximized. Lets users bind window maximize/restore to a key.
cantona
force-pushed
the
feat/bindable-togglemaximized
branch
from
July 23, 2026 04:39
41974e9 to
42e0641
Compare
Contributor
Author
|
@raphamorim this is quality of life little patch. Please comment. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action::ToggleMaximizedexisted but was never wired up — it had no action-string mapping (so[bindings]couldn't reference it) and no handler. This adds:"togglemaximized"in the action-string parsertoggle_maximize_window()emittingRioEvent::ToggleMaximizedAct::ToggleMaximizedarmwinit_window.set_maximized()(works on Wayland)So users can bind window maximize/restore, e.g.
{ key = "m", with = "super", action = "togglemaximized" }.Standalone, based on main.