reload_lib -a: [Bug fix] Compares against default branch

[g0tmi1k]

There was a bug with reload_lib -a not working.

Note: master is the default branch for this git repo.

Before

$ git checkout master
[...]
$ ./msfconsole -q
msf > reload_lib
Usage: reload_lib lib/to/reload.rb [...]

Reload Ruby library files from specified paths.

    -h, --help                       Help banner.
    -a, --all                        Reload all* changed files in your current Git working tree.
                                     *Excludes modules and non-Ruby files.
msf > reload_lib -h
Usage: reload_lib lib/to/reload.rb [...]

Reload Ruby library files from specified paths.

    -h, --help                       Help banner.
    -a, --all                        Reload all* changed files in your current Git working tree.
                                     *Excludes modules and non-Ruby files.
msf > reload_lib -a
Usage: reload_lib lib/to/reload.rb [...]

Reload Ruby library files from specified paths.

    -h, --help                       Help banner.
    -a, --all                        Reload all* changed files in your current Git working tree.
                                     *Excludes modules and non-Ruby files.
msf >

After

$ git checkout  reload_all
[...]
$ ./msfconsole -q
msf > reload_lib -a
[*] Reloading /usr/share/metasploit-framework2/lib/msf/ui/console/command_dispatcher/developer.rb
msf >

[adfoster-r7]

Looks like this would break the reload_lib functionality for my env, since my origin/master is never in sync with upstream/master 👀

Do we want to add a config option or something similar to support this workflow maybe, to avoid potentially breaking for other folk's envs? 🤔

[g0tmi1k]

@adfoster-r7 - Good point! Didn't think about that.
Following: https://docs.metasploit.com/docs/development/get-started/setting-up-a-metasploit-development-environment.html

It says about adding a upstream remote - so it will now attempt to use that first.

Not sure if its on the cards from merging form master to main as the default branch, but incase it is, Ive added that in now...