fix: handle ActiveRecord::RecordInvalid in ssh_creds when workspace is reset#21536
Open
4ravind-b wants to merge 1 commit into
Open
fix: handle ActiveRecord::RecordInvalid in ssh_creds when workspace is reset#215364ravind-b wants to merge 1 commit into
4ravind-b wants to merge 1 commit into
Conversation
Contributor
Author
|
Verified on Metasploitable2. Before this fix: Running the module after deleting the workspace with After this fix: The module no longer crashes. Instead, it prints a warning when credential storage fails and continues processing the remaining files. All SSH files are successfully downloaded, post-module execution completes normally, and the session remains active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21480
When
workspace -Dis run while a session is active, the session'sdatabase record gets deleted but the session itself stays alive. When
post/multi/gather/ssh_credstries to save credentials, it fails withActiveRecord::RecordInvalid: Session can't be blankand crashes the module.This fix adds a rescue for
ActiveRecord::RecordInvalidso the moduleprints a warning and continues instead of crashing.
Verification
post/multi/gather/ssh_creds— works fineworkspace -Dpost/multi/gather/ssh_credsagain