Improve performance of label2rgb
#839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
improvement
grlee77
force-pushed
the
label2rgb-performance
branch
from
aaad6f2 to
3cc00cb
Compare
also address various issues in the benchmarks * use int32 dtype for the labels during benchmarks * Fix label2rgb benchmark bug where 3rd dimension was truncated. * Use n-d blobs image as a more realistic label image.
grlee77
force-pushed
the
label2rgb-performance
branch
from
3cc00cb to
9df629a
Compare
gigony
reviewed
Feb 19, 2025
| if (label == bg_label) { | ||
| out[3*i] = bg_color[0]; | ||
| out[3*i + 1] = bg_color[1]; | ||
| out[3*i + 1] = bg_color[2]; |
There was a problem hiding this comment.
I wonder if this original index is correct or not. I guess it should be:
Suggested change
| out[3*i + 1] = bg_color[2]; | |
| out[3*i + 2] = bg_color[2]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR substantially improves the performance of
label2rgbby using custom elementwise kernels.A few fixes in the benchmark scripts were also made
Accelerations vs skimage before vs. after this change (when
imageis used it hasdtype=np.float32)